Thread (1 message) 1 message, 1 author, 2015-07-21

Re: [PATCH] netcp:Fix error handling in the function netcp_xgbe_serdes_config

From: Murali Karicheri <hidden>
Date: 2015-07-21 14:57:26
Also in: lkml

On 07/20/2015 11:54 AM, Nicholas Krause wrote:
quoted hunk
This fixes error handling in the function netcp_xgbe_serdes_config
by putting the return value of netcp_xgbe_serdes_check_lane into
the variable ret and return this value to the caller as this function
can fail when called by returning the error code -ETIMEOUT.

Signed-off-by: Nicholas Krause <redacted>
---
  drivers/net/ethernet/ti/netcp_xgbepcsr.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/netcp_xgbepcsr.c b/drivers/net/ethernet/ti/netcp_xgbepcsr.c
index 33571ac..0c79e3d 100644
--- a/drivers/net/ethernet/ti/netcp_xgbepcsr.c
+++ b/drivers/net/ethernet/ti/netcp_xgbepcsr.c
@@ -483,7 +483,7 @@ static int netcp_xgbe_serdes_config(void __iomem *serdes_regs,
  		return ret;

  	netcp_xgbe_serdes_enable_xgmii_port(sw_regs);
-	netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs);
+	ret = netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs);
  	return ret;
  }
Nicholas,

Thanks for the patch.

Acked-by: Murali Karicheri <redacted>

-- 
Murali Karicheri
Linux Kernel, Keystone
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help