Re: [virtio-dev] [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2015-07-15 12:55:18
Also in:
lkml, virtualization
From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2015-07-15 12:55:18
Also in:
lkml, virtualization
On 15/07/2015 14:26, Michael S. Tsirkin wrote:
ANY_LAYOUT is a compatibility feature. It's implied for VERSION_1 devices, and non-transitional devices might not offer it. Change code to behave accordingly. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 63c7810..7fbca37 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c@@ -1828,7 +1828,8 @@ static int virtnet_probe(struct virtio_device *vdev) else vi->hdr_len = sizeof(struct virtio_net_hdr); - if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT)) + if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT) || + virtio_has_feature(vdev, VIRTIO_F_VERSION_1)) vi->any_header_sg = true; if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>