Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

On Fri, Jul 10, 2015 at 07:06:23PM -0400, Chris Metcalf wrote:

On 7/10/2015 6:45 PM, Josh Cartwright wrote:

quoted

quoted

+static inline const struct cpumask *housekeeping_cpumask(void)

quoted

+{
+#ifdef CONFIG_NO_HZ_FULL
+	if (tick_nohz_full_enabled())
+		return housekeeping_mask;
+#endif

Just a small comment:

We can take these checks out from under a #ifdef CONFIG_NO_HZ_FULL
check, given that are stubbed tick_nohz_full_enabled() defined above.

True for the "if" clause, but the "housekeeping_mask" variable is only defined
under CONFIG_NO_HZ_FULL.

Indeed!  I should have read more carefully.

Sorry for the noise.

  Josh