-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Friday, July 31, 2015 6:55 AM
To: shh.xie@gmail.com
Cc: netdev@vger.kernel.org; f.fainelli@gmail.com; Xie Shaohui-B21989
Subject: Re: [PATCH][v2] net: phy: add driver for aquantia phy

From: <redacted>
Date: Thu, 30 Jul 2015 12:17:15 +0800

quoted

+static int aquantia_soft_reset(struct phy_device *phydev) {
+	return 0;
+}
+
+static int aquantia_config_init(struct phy_device *phydev) {
+	return 0;
+}

You shouldn't need to implement these methods at all, just leave them
NULL in the driver struct.

The only thing implementing them as nop routines like this does is make
the PHY fixups get scanned.  And I don't think there are any for this
device.

[S.H] OK. Will remove the nop routines in next version.
Thanks!

Shaohui