Re: [PATCH net-next] r8169:Place dma_alloc_coherent on interrupt context
From: David Miller <davem@davemloft.net>
Date: 2015-07-30 20:45:27
From: Corcodel Marian <redacted> Date: Thu, 30 Jul 2015 22:33:21 +0300
quoted hunk ↗ jump to hunk
According to this doc https://www.kernel.org/doc/Documentation/DMA-API.txt dma_alloc_coherent must run on interrupt context, and flush the chip before use. Signed-off-by: Corcodel Marian <redacted>diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3df51fa..edce264 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c@@ -7535,15 +7535,15 @@ static void rtl8169_down(struct net_device *dev) rtl_pll_power_down(tp); } -static int rtl8169_close(struct net_device *dev) +/*static int rtl8169_close(struct net_device *dev)
This really isn't acceptable.