RE: drivers/net/phy/dp83867.c:167: possible bad if ?

Hello there,

----------------------------------------

The proposed fix is logically correct. And it matches the code for
phy_interface_is_rgmii with the '&&'.

As the original warning message indicates, I used compiler flag
-Wlogical-op to find this problem.

In order to detect this problem in future in your section of
the Linux kernel, it might be a wise idea to add compiler flag
-Wlogical-op to your builds.

If all goes well, this extra compiler flag should have nothing to say.

Just an idea.


Regards

David Binderman