Re: [PATCH net-next 3/6] net_sched: act: make tcfg_pval non zero

Thanks guys for the review.

For completeness, I'll add smp_wmb() here :

    gact->tcfg_pval    = max_t(u16, 1, p_parm->pval);
    smp_wmb();
    gact->tcfg_ptype   = p_parm->ptype;

And corresponding smp_rmb()

On Fri, Jul 3, 2015 at 12:49 PM, Jamal Hadi Salim [off-list ref] wrote:

On 07/02/15 09:07, Eric Dumazet wrote:

quoted

First step for gact RCU operation :

Instead of testing if tcfg_pval is zero or not, just make it 1.

No change in behavior, but slightly faster code.

Signed-off-by: Eric Dumazet <redacted>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal