Thread (3 messages) 3 messages, 3 authors, 2015-07-02

Re: [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again

From: Toshiaki Makita <hidden>
Date: 2015-07-02 15:46:23
Also in: bridge

On 15/07/02 (木) 21:48, Nikolay Aleksandrov wrote:
Vlan ids 0 and 4095 were disallowed by commit:
8adff41c3d25 ("bridge: Don't use VID 0 and 4095 in vlan filtering")
but then the check was removed when vlan ranges were introduced by:
bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
So reintroduce the vlan range check.
Before patch:
[root@testvm ~]# bridge vlan add vid 0 dev eth0 master
(succeeds)
After Patch:
[root@testvm ~]# bridge vlan add vid 0 dev eth0 master
RTNETLINK answers: Invalid argument

Signed-off-by: Nikolay Aleksandrov <redacted>
Fixes: bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
Thank you for fixing this.

Acked-by: Toshiaki Makita <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help