Re: [PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor()

On 10 June 2015 at 21:52 Joe Perches [off-list ref] wrote:


On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote:

quoted

Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

[]

quoted

diff --git a/drivers/net/wireless/ath/ath5k/phy.c

b/drivers/net/wireless/ath/ath5k/phy.c

[]

quoted

@@ -1566,17 +1566,13 @@ static s16
 ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah)
 {
    s16 sort[ATH5K_NF_CAL_HIST_MAX];
-   s16 tmp;
    int i, j;

    memcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort));
    for (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) {
            for (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) {
-                   if (sort[j] > sort[j - 1]) {
-                           tmp = sort[j];
-                           sort[j] = sort[j - 1];
-                           sort[j - 1] = tmp;
-                   }
+                   if (sort[j] > sort[j - 1])
+                           swap(sort[j], sort[j]);

swap(a, a) doesn't look useful.

Thanks a lot Joe, I'll fix this one :)

Regards,
Fabian

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html