RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
From: Jianhua Xie <hidden>
Date: 2015-06-10 06:00:28
Also in:
linuxppc-dev, lkml
-----Original Message----- From: Linuxppc-dev [mailto:linuxppc-dev- bounces+jianhua.xie=freescale.com@lists.ozlabs.org] On Behalf Of Madalin Bucur Sent: Wednesday, April 29, 2015 10:57 PM To: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org; Bucur Madalin-Cristian-B32716 Subject: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet This introduces the Freescale Data Path Acceleration Architecture (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, BMan, PAMU and FMan drivers to deliver Ethernet connectivity on the Freescale DPAA QorIQ platforms.
Snip......
+ + if (unlikely(dpa_xmit(priv, percpu_stats, queue_mapping, &fd) < 0)) + goto xmit_failed; + + net_dev->trans_start = jiffies;
It is probably better to use netdev_queue->trans_start to instead of net_dev->trans_start on SMP. Best Regards, Jianhua
+ return NETDEV_TX_OK;
+
+xmit_failed:
+ if (fd.cmd & FM_FD_CMD_FCO) {
+ (*countptr)--;
+ dpa_fd_release(net_dev, &fd);
+ percpu_stats->tx_errors++;
+ return NETDEV_TX_OK;
+ }
+ _dpa_cleanup_tx_fd(priv, &fd);
+ percpu_stats->tx_errors++;
+ dev_kfree_skb(skb);
+ return NETDEV_TX_OK;
+}
--
1.7.11.7
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev