Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2015-06-26 16:41:37
On 25/06/15 06:50, giladb@ezchip.com wrote:
From: Gilad Ben-Yossef <gilad@benyossef.com> DSA master netdev promiscuity counter was not being properly decremented on slave device open error path. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> CC: Gilad Ben-Yossef <redacted> CC: David S. Miller <davem@davemloft.net> CC: Florian Fainelli <f.fainelli@gmail.com> CC: Guenter Roeck <linux@roeck-us.net> CC: Andrew Lunn <andrew@lunn.ch> CC: Scott Feldman <redacted>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
quoted hunk ↗ jump to hunk
--- net/dsa/slave.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 04ffad3..0917123 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c@@ -112,7 +112,7 @@ static int dsa_slave_open(struct net_device *dev) clear_promisc: if (dev->flags & IFF_PROMISC) - dev_set_promiscuity(master, 0); + dev_set_promiscuity(master, -1); clear_allmulti: if (dev->flags & IFF_ALLMULTI) dev_set_allmulti(master, -1);
-- Florian