Thread (1 message) 1 message, 1 author, 2015-06-25

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

From: Oliver Neukum <hidden>
Date: 2015-06-25 09:55:08

On Tue, 2015-06-23 at 00:32 +0200, Enrico Mioso wrote:
+/* XXX rewrite, not multipacket */
Can you explain what you want to do here?
+struct sk_buff *
+huawei_ncm_tx_fixup(struct usbnet *dev, struct sk_buff *skb_in, gfp_t flags) {
+	struct huawei_cdc_ncm_state *drvstate = (void *)&dev->data;
+	struct cdc_ncm_ctx *ctx = drvstate->ctx;
+	struct sk_buff *skb_out;
+	int status;
+
+	skb_out = alloc_skb(ctx->tx_max, GFP_ATOMIC);
You must test this for NULL

	Regards
		Oliver



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help