Re: [PATCH net] udp: fix behavior of wrong checksums
From: David Miller <davem@davemloft.net>
Date: 2015-06-01 04:42:52
From: David Miller <davem@davemloft.net>
Date: 2015-06-01 04:42:52
From: Eric Dumazet <redacted> Date: Sat, 30 May 2015 09:16:53 -0700
From: Eric Dumazet <edumazet@google.com> We have two problems in UDP stack related to bogus checksums : 1) We return -EAGAIN to application even if receive queue is not empty. This breaks applications using edge trigger epoll() 2) Under UDP flood, we can loop forever without yielding to other processes, potentially hanging the host, especially on non SMP. This patch is an attempt to make things better. We might in the future add extra support for rt applications wanting to better control time spent doing a recv() in a hostile environment. For example we could validate checksums before queuing packets in socket receive queue. Signed-off-by: Eric Dumazet <edumazet@google.com>
Yeah this looks correct, applied and queued up for -stable. Thanks!