Re: [PATCHv3] pktgen: Convert return type of process_ipsec to bool
From: Jesper Dangaard Brouer <hidden>
Date: 2015-05-28 10:11:19
Also in:
lkml
On Thu, 28 May 2015 00:11:05 -0400 Nicholas Krause [off-list ref] wrote:
quoted hunk
This converts the function, process_ipsec to the return type of bool due to only returning either one or zero. Signed-off-by: Nicholas Krause <redacted> --- v3 Move the v2 changes below the sign off line for this patch. v2 Change incorrect patch subject and make commit message clearer net/core/pktgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 508155b..33bdb76 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c@@ -2587,7 +2587,7 @@ static void free_SAs(struct pktgen_dev *pkt_dev) } } -static int process_ipsec(struct pktgen_dev *pkt_dev, +static bool process_ipsec(struct pktgen_dev *pkt_dev, struct sk_buff *skb, __be16 protocol)
When doing this change, could you please align the above line to the open parenthesis of process_ipsec (even-though it was also misaligned before). scripts/checkpatch.pl will tell you: CHECK: Alignment should match open parenthesis Did anyone tell you that kernel developers nitpick? ;-) And usually you don't need to Cc the "main" Linux Kernel Mailing List (linux-kernel@vger.kernel.org) with a trivial patch like this. Sending it to the network developers should be enough (netdev@vger.kernel.org). -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer