Thread (2 messages) flat view 2 messages, 2 authors, 2015-05-18

Re: [PATCH net-next] netfilter: Use correct return for seq_show functions

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2015-05-18 15:53:15
Also in: lkml, netfilter-devel

On Tue, May 12, 2015 at 06:28:23PM -0700, Joe Perches wrote:
Using seq_has_overflowed doesn't produce the right return value.
Either 0 or -1 is, but 0 is much more common and works well when
seq allocation retries.

I believe this doesn't matter as the initial allocation is always
sufficient, this is just a correctness patch.

Miscellanea:

o Don't use strlen, use *ptr to determine if a string
  should be emitted like all the other tests here
o Delete unnecessary return statements
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help