Re: [PATCH v4] net: phy: micrel: Fix regression in kszphy_probe

From
Fabio Estevam <festevam@gmail.com>
Date
2015-05-11 15:31:16
Also in
lkml, stable
Reply to
Niklas Cassel, 2015-05-11
On Mon, May 11, 2015 at 12:21 PM, Niklas Cassel [off-list ref] wrote:
Don't do clock-mode-select if clk == NULL,
since when building without CONFIG_HAVE_CLK,
clk_get returns NULL and clk_get_rate returns 0.

Doing clock-mode-select in this cause causes kszphy_probe to
return -EINVAL and thus prevents the device from being probed.

The original code (before regression) would return 0
when building without CONFIG_HAVE_CLK.

Cc: stable <redacted> # 3.18+
1fadee0c3645 ("net/phy: micrel: Add clock support for
KSZ8021/KSZ8031")
Signed-off-by: Niklas Cassel <redacted>
Looks good now:

Reviewed-by: Fabio Estevam <redacted>
Thread (3 messages) 3 messages, 3 authors, last reply 2015-05-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help