Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo
From: Vivien Didelot <hidden>
Date: 2015-05-29 15:38:32
From: Vivien Didelot <hidden>
Date: 2015-05-29 15:38:32
Hi, ----- On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz.or@gmail.com wrote:
On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot [off-list ref] wrote:quoted
@@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct device*parent, if (slave_dev == NULL) return -ENOMEM; - slave_dev->features = master->vlan_features; + slave_dev->features = master->vlan_features | + NETIF_F_VLAN_FEATURES | + NETIF_F_HW_SWITCH_OFFLOAD;wait... didn't commit 7889cbee8357aaed85898d028829dfb4f75bae2c remove NETIF_F_HW_SWITCH_OFFLOAD?
Indeed, note that this RFC is based on v4.1-rc3. This will become unneeded I guess. BTW, given the commit message, I didn't really understand why? Thanks, -v