Re: [PATCH iproute2] ss: Fix allocation of cong control alg name
From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2015-05-29 11:11:38
From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2015-05-29 11:11:38
On 05/29/2015 01:04 PM, Eric Dumazet wrote: ...
I doubt TCP_CA_NAME_MAX will ever change in the kernel : 16 bytes. Its typically "cubic" and less than 8 bytes. Using 8 bytes to point to a malloc(8) is a waste. Please remove the memory allocation, or store the pointer, since tcp_show_info() does the malloc()/free() before return.
+1, much better