Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys
From: Eric Dumazet <hidden>
Date: 2015-05-28 21:44:59
On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote:
quoted hunk ↗ jump to hunk
@@ -566,11 +640,15 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = { }, { .key_id = FLOW_DISSECTOR_KEY_IPV4_ADDRS, - .offset = offsetof(struct flow_keys, addrs), + .offset = offsetof(struct flow_keys, addrs.v4addrs), + }, + { + .key_id = FLOW_DISSECTOR_KEY_IPV6_ADDRS, + .offset = offsetof(struct flow_keys, addrs.v6addrs), }, { .key_id = FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS, - .offset = offsetof(struct flow_keys, addrs), + .offset = offsetof(struct flow_keys, addrs.v4addrs),
Shouldn't it be offsetof(struct flow_keys, addrs.v6addrs), ?