From: Or Gerlitz <redacted>
Date: Mon, 25 May 2015 22:07:23 +0300

On Wed, May 20, 2015 at 5:17 PM, Amir Vadai [off-list ref] wrote:

quoted

On Tue, May 19, 2015 at 7:41 PM, David Miller [off-list ref] wrote:

quoted

From: Amir Vadai <redacted>
Date: Tue, 19 May 2015 12:25:12 +0300

quoted

On Sun, May 17, 2015 at 8:05 PM, David Miller [off-list ref] wrote:

quoted

From: Amir Vadai <redacted>
Date: Sun, 17 May 2015 16:02:11 +0300

quoted

We didn't get a response yet regarding your comment about the irq
renaming [3].

Well then, please hold off on resubmissions of this series until you
do get a response and that issue is firmly resolved.

Hi,

I don't mean to push you, I only want to understand what is expected
from me and what are the next steps:
How will the issue be resolved? Do you plan to answer my question [1]
from last week, and just too busy right now or something like that?

I have not seen any response to me explaining why it's ok to change
the IRQ name strings in the context where this will occur.

Once you explain that, we can make forward progress, but only at that
point.

Hi Dave,

Just to put us back on the same page, repeating a bit the previous chapters..

You wrote [1] that if we change these names after the request_irq() call(s), the
new name string will not propagate to /proc/interrupts output.

So, indeed, request_irq() is called when the driver is loaded (and we
don't know yet if the port types are Infiniband or Ethernet). Only later
on, we rename the name when the Ethernet interface is up and we know
its name.

Fact is that the new name does propagate to /proc/interrupts.

Also, looking in the code, I don't see a reason why shouldn't it
be properly updated. When calling request_irq(), the name argument
is not copied, but irq_desc->action->name points to it. This same pointer
is being used by show_interrupts() when /proc/interrupts is shown.

The problem is, applications might cache the name of the interrupt source
from /proc/interrupts or elsewhere as soon as the device is instantiated.

You cannot change it after you've published it there.

Therefore, it is mandatory that the name string is at the time you call
request_irq().