Re: [PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic

[PATCH v4 net-next 00/11] net: Increase inputs to flow_keys hashing · Tom Herbert <hidden> · 2015-05-22
[PATCH v4 net-next 01/11] net: Simplify GRE case in flow_dissector · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 01/11] net: Simplify GRE case in flow_dissector · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
[PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
[PATCH v4 net-next 04/11] net: Get skb hash over flow_keys structure · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 04/11] net: Get skb hash over flow_keys structure · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
[PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys · Cong Wang <hidden> · 2015-05-22
Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys · Tom Herbert <hidden> · 2015-05-22
[PATCH v4 net-next 06/11] net: Add keys for TIPC address · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 06/11] net: Add keys for TIPC address · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
[PATCH v4 net-next 08/11] net: Add VLAN ID to flow_keys · Tom Herbert <hidden> · 2015-05-22
[PATCH v4 net-next 07/11] net: Get rid of IPv6 hash addresses flow keys · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 07/11] net: Get rid of IPv6 hash addresses flow keys · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
[PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys · Tom Herbert <hidden> · 2015-05-22
[PATCH v4 net-next 10/11] net: Add GRE keyid in flow_keys · Tom Herbert <hidden> · 2015-05-22
[PATCH v4 net-next 11/11] mpls: Add MPLS entropy label in flow_keys · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 11/11] mpls: Add MPLS entropy label in flow_keys · Jiri Pirko <jiri@resnulli.us> · 2015-05-22
[PATCH v4 net-next 02/11] mpls: Add definition for IPPROTO_MPLS · Tom Herbert <hidden> · 2015-05-22
Re: [PATCH v4 net-next 02/11] mpls: Add definition for IPPROTO_MPLS · Jiri Pirko <jiri@resnulli.us> · 2015-05-22

From: Jiri Pirko <jiri@resnulli.us>
Date: 2015-05-22 06:37:55

Fri, May 22, 2015 at 02:11:38AM CEST, tom@herbertland.com wrote:

key_basic is set twice in __skb_flow_dissect which seems unnecessary.
Remove second one.

Signed-off-by: Tom Herbert <redacted>

I have the same patch in my queue :)

Acked-by: Jiri Pirko <jiri@resnulli.us>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help