On Fri, 2015-05-15 at 12:49 -0400, David Miller wrote:

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 14 May 2015 14:02:30 +0800

quoted

On Thu, May 14, 2015 at 01:58:24PM +0800, Herbert Xu wrote:

quoted

This patch also removes a bogus socket lock introduced by that
very same patch.

This bogus socket lock is still there in the current tree.

---8<---
The commit c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink:
eliminate nl_sk_hash_lock") added a lock_sock to netlink_insert
with no justifications whatsoever.

This patch kills it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Eric, does this improve your benchmark?

I don't think so, but I can test this in about one hour.