Re: [PATCH net-next] tcp: provide SYN headers for passive connections

On Tue, 2015-05-05 at 16:05 -0400, David Miller wrote:

Applied, but I think you should give maybe a little bit more thought
into the behavior when a not-large-enough buffer is supplied by the
user.

Since we're talking about things on the order of 60 bytes or so at
most, it seems clear to me that signalling an error is probably the
most advisable thing to do in this situation.

Maybe you could signal an error, yet write the actual length to
"optlen".  That way the user can figure out how much they need.  Then
they at least would have the option of retrying with a larger buffer.

Seems fine to me, I'll provide a patch implementing your suggestions.

Thanks.