Re: [PATCH resend] Renesas Ethernet AVB driver
From: Richard Cochran <richardcochran@gmail.com>
Date: 2015-04-14 05:27:29
Also in:
linux-devicetree, linux-sh
From: Richard Cochran <richardcochran@gmail.com>
Date: 2015-04-14 05:27:29
Also in:
linux-devicetree, linux-sh
On Mon, Apr 13, 2015 at 11:23:26PM +0300, Sergei Shtylyov wrote:
quoted
quoted
This is a bit hacky. Can't your driver make sure that the HW is ready?quoted
Will look into this. Perhaps it's a remainder from when the PTP driver was separate...No, we enter this mode upon closing the Ethernet device and when the ring DMA sizes are changed. Seems unavoidable...quoted
quoted
quoted
+ if (ravb_read(priv->ndev, CSR) & CSR_OPS_CONFIG) + return true; + else + return false;
It is surely avoidable. The driver knows (or should know) whether or not the hardware has been configured or not. Thanks, Richard