Thread (6 messages) flat view 6 messages, 2 authors, 2015-03-25

Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

From: Alexey Kodanev <hidden>
Date: 2015-03-23 15:51:01
Also in: lkml

Hi Eric,
On 03/23/2015 05:38 PM, Eric Dumazet wrote:
On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote:
\
quoted
@@ -1538,7 +1525,7 @@ do_time_wait:
  					    &ipv6_hdr(skb)->saddr, th->source,
  					    &ipv6_hdr(skb)->daddr,
  					    ntohs(th->dest), tcp_v6_iif(skb));
-		if (sk2 != NULL) {
+		if (sk2) {
  			struct inet_timewait_sock *tw = inet_twsk(sk);
  			inet_twsk_deschedule(tw, &tcp_death_row);
  			inet_twsk_put(tw);
And please refrain adding such cleanup changes in a bug fix.
Sure, I will. Thank you for review!

Best regards,
Alexey
Thanks !
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help