Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

On Sunday 22 March 2015, Richard Cochran wrote:

On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote:

quoted

On Saturday 21 March 2015, Richard Cochran wrote:

quoted

        mutex_lock(&clock->extreg_lock);
 
-       err = tdr_write(1, phydev, ts, PTP_LOAD_CLK);
+       err = tdr_write(1, phydev, &ts, PTP_LOAD_CLK);
 
        mutex_unlock(&clock->extreg_lock);

I don't see the change to the tdr_write() function that changes the 
argument from 'struct timespec ts' to 'struct timespec64 *', so this
looks wrong to me.

There is a 'ts64' parameter, converted to 'ts' beforehand.

Ok, got it. The code looks correct then, though I'd like to see the use
of 'timespec' pushed out as far as possible. How about changing the
type for tdr_write() as well here?

tdr_write() itself should be fine until 2106, as it writes an unsigned number,
but it's probably good to document that inside of that function.

	Arnd