Thread (5 messages) flat view 5 messages, 3 authors, 2015-03-18

Re: [RFC PATCH] xen-netback: making the bandwidth limiter runtime settable

From: Ian Campbell <hidden>
Date: 2015-03-17 11:26:48
Also in: lkml

On Fri, 2015-03-13 at 13:51 +0100, Imre Palik wrote:
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 3aa8648..34d8038 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -463,6 +463,7 @@ int xenvif_init_queue(struct xenvif_queue *queue)
 	queue->credit_bytes = queue->remaining_credit = ~0UL;
 	queue->credit_usec  = 0UL;
 	init_timer(&queue->credit_timeout);
+	queue->credit_timeout.function = xenvif_tx_credit_callback;
 	queue->credit_window_start = get_jiffies_64();
 
 	queue->rx_queue_max = XENVIF_RX_QUEUE_BYTES;
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index cab9f52..bcc1880 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
[...]
quoted hunk ↗ jump to hunk
@@ -1170,7 +1170,7 @@ static bool tx_credit_exceeded(struct xenvif_queue *queue, unsigned size)
 		queue->credit_timeout.data     =
 			(unsigned long)queue;
 		queue->credit_timeout.function =
-			tx_credit_callback;
+			xenvif_tx_credit_callback;
Are this init and the one in xenvif_init_queue really both needed?

Ian.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help