Re: [PATCH net] openvswitch: Return vport module ref before destruction
From: David Miller <davem@davemloft.net>
Date: 2015-03-31 20:00:36
From: David Miller <davem@davemloft.net>
Date: 2015-03-31 20:00:36
From: Thomas Graf <tgraf@suug.ch> Date: Mon, 30 Mar 2015 13:57:41 +0200
Return module reference before invoking the respective vport
->destroy() function. This is needed as ovs_vport_del() is not
invoked inside an RCU read side critical section so the kfree
can occur immediately before returning to ovs_vport_del().
Returning the module reference before ->destroy() is safe because
the module unregistration is blocked on ovs_lock which we hold
while destroying the datapath.
Fixes: 62b9c8d0372d ("ovs: Turn vports with dependencies into separate modules")
Reported-by: Pravin Shelar <redacted>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---
@Dave: Please also queue for 3.19.x stable seriesApplied and queued up for -stable, thanks Thomas.