Thread (9 messages) 9 messages, 4 authors, 2015-03-31

Re: [PATCH net 3/4 v2] ipvlan: do not use rcu operations for address list

From: Cong Wang <hidden>
Date: 2015-03-31 18:35:59 

(Sorry for being late)

On Sat, Mar 28, 2015 at 11:13 AM, Jiri Benc [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -640,7 +640,7 @@ static void ipvlan_del_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
                return;

        ipvlan_ht_addr_del(addr, true);
-       list_del_rcu(&addr->anode);
+       list_del(&addr->anode);
        ipvlan->ipv6cnt--;
        WARN_ON(ipvlan->ipv6cnt < 0);
        kfree_rcu(addr, rcu);
But doesn't this mean kfree_rcu() can be replaced by kfree() too?
I noticed ipvlan_ht_addr_del() waits for RCU readers too.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help