Re: [PATCH net-next v10 3/7] ixgbe: Add a RETA query command to VF-PF channel API
From: Jeff Kirsher <hidden>
Date: 2015-03-31 07:35:37
Also in:
intel-wired-lan
On Mon, 2015-03-30 at 21:35 +0300, Vlad Zolotarov wrote:
Add this new command for 82599 and x540 devices only. Support for
other devices
will be added later.
82599 and x540 VFs and PF share the same RSS redirection table (RETA).
Therefore we
just return it for all VFs.
For 82599 and x540 RETA table is an array of 32 registers (128 bytes)
and the maximum number of
registers that may be delivered in a single VF-PF channel command is
15. Therefore
we will deliver the whole table in 3 steps: 12, 12 and 8 registers in
each
step correspondingly.
Thus this patch does the following:
- Adds a new API version (to specify a new commands set).
- Adds the IXGBE_VF_GET_RETA command to the VF-PF commands set.
Signed-off-by: Vlad Zolotarov <redacted>
---
New in v10:
- Drop the PRSTYPE reading since it's VF that finally modifies it
(via VFPSRTYPE)
and we will add the proper masking at the VF driver level.
- Return more self-explaining values.
New in v9:
- Reduce the support to 82599 and x540 devices only.
- Improvements in query RETA VF-PF command implementation:
- Use the cached RETA contents.
- Compress the mailbox message.
New in v5:
- Use the newly added netdev op to allow/prevent the RETA query on
a per-VF basis.
New in v4:
- Deleted an empty line in ixgbe_get_vf_reta() switch-case.
New in v3:
- Pass the number of dwords and offset in RETA in the
IXGBE_VF_GET_RETA request message.
This allows to reduce the added command set to a single command.
- Added a support for all devices supported by the ixgbe driver
that have
SR-IOV functions support: 82599, x540 and x550. The original code
supported
only 82599 and x540.
- Added the masking of the RETA entries according to the
PSRTYPE[n].RQPL
value.
New in v1 (compared to RFC):
- Use "if-else" statement instead of a "switch-case" for a single
option case
(in ixgbe_get_vf_reta()).
---
drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 4 +++
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 35
++++++++++++++++++++++++++
2 files changed, 39 insertions(+)Thanks Vlad, applied to my queue. -- git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
Attachments
- signature.asc [application/pgp-signature] 819 bytes