On Mon, Mar 30, 2015 at 5:02 PM, Alexander Duyck
[off-list ref] wrote:

On 03/30/2015 04:47 PM, Cong Wang wrote:

quoted

As long as we agree rtnl lock should be taken, you already take my point
here ($subject says so).

Yes, I agree lock can be held.  For fib4 it was already holding the RTNL
lock when it made that call.  You can update the other users of
fib_rules_unregister so that they call it with the RTNL lock held as well.

quoted

It is just API change to move rtnl_lock up to caller or whatever
appropriate.

Right, so like I said for fib4 this is resolved.  That just leaves ipmr,
ip6mr, fib6, and dn_rules that need to be updated so that they correctly
handle the RTNL locking in their exit/cleanup paths. Since you already have
some related patches out for these I will let you take them otherwise I
might try to go through and clean them up next week.

Ok, then we are finally on the same page. We need two patches:

1) move unregister under rtnl lock (as what this patch intended to do)
2) remove the unnecessary rules_mod_lock

Thanks.