Re: [PATCH 1/2] ipvlan: don't loose broadcast MAC when setting MAC filters
From: Mahesh Bandewar <hidden>
Date: 2015-03-30 20:29:07
On Thu, Mar 26, 2015 at 3:41 PM, Dan Williams [off-list ref] wrote:
The broadcast MAC is supposed to be allowed whenever the device has an IPv4 address, otherwise ARP requests get dropped on the floor. If ndo_set_rx_mode (and thus ipvlan_set_multicast_mac_filter()) gets called after the address was added, it blows away the broadcast MAC address in mac_filters that was added at IPv4 address addition. Fix that. Signed-off-by: Dan Williams <redacted>
Acked-by: Mahesh Bandewar <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/ipvlan/ipvlan_main.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 4f4099d..d34f580 100644 --- a/drivers/net/ipvlan/ipvlan_main.c +++ b/drivers/net/ipvlan/ipvlan_main.c@@ -241,6 +241,9 @@ static void ipvlan_set_multicast_mac_filter(struct net_device *dev) bitmap_copy(ipvlan->mac_filters, mc_filters, IPVLAN_MAC_FILTER_SIZE); + + if (ipvlan->ipv4cnt) + ipvlan_set_broadcast_mac_filter(ipvlan, true); } dev_uc_sync(ipvlan->phy_dev, dev); dev_mc_sync(ipvlan->phy_dev, dev); --2.1.0