On Mon, Mar 30, 2015 at 6:00 PM, roopa [off-list ref] wrote:

On 3/30/15, 6:11 AM, Andy Gospodarek wrote:

quoted

On Mon, Mar 30, 2015 at 02:00:25PM +0200, Jiri Pirko wrote:

quoted

Mon, Mar 30, 2015 at 10:40:18AM CEST, sfeldma@gmail.com wrote:

quoted

From: Scott Feldman <redacted>

The main theme of this patch set is to cleanup swdev in preparation for
new features or fixes to be added soon.  We have a pretty good idea now
how
to handle stacked drivers in swdev, but there where some loose ends.
For
example, if a set failed in the middle of walking the lower devs, we
would
leave the system in an undefined state...there was no way to recover
back to
the previous state.  Speaking of sets, also recognize a pattern that
most
swdev API accesses are gets or sets of port attributes, so go ahead and
make
port attr get/set the central swdev API, and convert everything that is
set-ish/get-ish to this new API.

Features/fixes that should follow from this cleanup:

- solve the duplicate pkt forwarding issue
- get/set bridge attrs, like ageing_time, from/to device
- get/set more bridge port attrs from/to device

There are some rename cleanups tagging along at the end, to give swdev
consistent naming.

As you can see in the switchdev patch submission history, I originally
pushed this with "swdev_" previx. Turned out people did not like that
because "sw" can be easily misunderstood as "software".

I agree with this.

agree. maybe just "switchdev_" will be better.

Also, how about prefixing the ops names supported by switchdev with
"sdo_" e.g as we have ndo_ prefix for "plain" netdevs?