Re: [PATCH 1/6] rtlwifi: Use common rtl_query_rxpwrpercentage function
From: Joe Perches <hidden>
Date: 2015-03-11 20:19:42
Also in:
linux-wireless
On Wed, 2015-03-11 at 22:03 +0200, Priit Laes wrote:
quoted hunk
diff --git a/drivers/net/wireless/rtlwifi/stats.c b/drivers/net/wireless/rtlwifi/stats.c
[]
quoted hunk
@@ -26,14 +26,14 @@ #include "stats.h" #include <linux/export.h> +/* TODO: Figure out a better name */ u8 rtl_query_rxpwrpercentage(char antpower) { if ((antpower <= -100) || (antpower >= 20)) return 0; else if (antpower >= 0) return 100; - else - return 100 + antpower; + return 100 + antpower;}
This is a superfluous change.
If it was changed because checkpatch emitted a warning,
there's a newer version of checkpatch that doesn't emit
a warning for this line.
If any change was to be made, I suggest reordering so
that the return values are written low to high like:
u8 rtl_query_rxpwrpercentage(char antpower)
{
if ((antpower <= -100) || (antpower >= 20))
return 0;
else if (antpower < 0)
return antpower + 100;
else
return 100;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html