Re: [PATCH] vxlan: Wrong type passed to %pIS

On Sat, Feb 07 2015, Joe Perches [off-list ref] wrote:

On Sat, 2015-02-07 at 03:17 +0100, Rasmus Villemoes wrote:

quoted

src_ip is a pointer to a union vxlan_addr, one member of which is a
struct sockaddr. Passing a pointer to src_ip is wrong; one should pass
the value of src_ip itself. Since %pIS formally expects something of
type struct sockaddr*, let's pass a pointer to the appropriate union
member, though this of course doesn't change the generated code.

Hello Rasmus

Are you finding these mismatches by hand or
are you using some tool?

I've extended smatch to do format checking (mostly for the %p
extensions; gcc already does all the other stuff just fine). I'll try
and see if I can get it on github sometime in the coming week.

Rasmus