Thread (42 messages) 42 messages, 8 authors, 2015-02-27

Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx switches

From: David Miller <davem@davemloft.net>
Date: 2015-02-27 22:21:08

From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 26 Feb 2015 15:44:33 +0100
Thu, Feb 26, 2015 at 03:19:27PM CET, sfeldma@gmail.com wrote:
quoted
Missing .ndo_start_xmit is the clue....do we need more?
You do not want to add null check for ndo_start_xmit to xmit path :)
This should be some stub in case of no-tx.
Cheapest would be to force the device to use the noop_qdisc which
simply throws all packets away.

No fast path tests whatsoever.

Or we can attach an ndo_start_xmit that drops packets too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help