Thread (18 messages) 18 messages, 7 authors, 2015-03-01

Re: [PATCH] net: do not use rcu in rtnl_dump_ifinfo()

From: Cong Wang <hidden>
Date: 2015-02-27 18:35:22

On Fri, Feb 27, 2015 at 9:19 AM, Daniel Borkmann [off-list ref] wrote:
On 02/27/2015 06:07 PM, Eric Dumazet wrote:
quoted
From: Eric Dumazet <edumazet@google.com>

We did a failed attempt in the past to only use rcu in rtnl dump
operations (commit e67f88dd12f6 "net: dont hold rtnl mutex during
netlink dump callbacks")

Now that dumps are holding RTNL anyway, there is no need to also
use rcu locking, as it forbids any scheduling ability, like
GFP_KERNEL allocations that controlling path should use instead
of GFP_ATOMIC whenever possible.

This should fix following splat Cong Wang reported :

===============================

[ Btw, I think patchwork has an issue with above line when fetching
  the mbox : it thinks commit description ends here. :(

  Prefixing with a space char should help to not get it lost. ]
To save everyone's time, either fix patchwork or teach checkpatch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help