Re: [PATCH net-next 1/7] net: bluetooth: compact struct bt_skb_cb by inlining struct hci_req_ctrl
From: Eyal Birger <hidden>
Date: 2015-02-26 21:22:51
From: Eyal Birger <hidden>
Date: 2015-02-26 21:22:51
Hi Marcel, On Thu, Feb 26, 2015 at 6:15 PM, Marcel Holtmann [off-list ref] wrote:
Hi Eyal,quoted
struct hci_req_ctrl is never used outside of struct bt_skb_cb; Inlining it frees 8 bytes on a 64 bit system in skb->cb[] allowing the addition of more ancillary data. Signed-off-by: Eyal Birger <redacted> --- include/net/bluetooth/bluetooth.h | 10 +++------- net/bluetooth/hci_core.c | 12 ++++++------ net/bluetooth/hci_event.c | 4 ++-- net/bluetooth/hci_request.c | 6 +++--- net/bluetooth/hci_sock.c | 2 +- 5 files changed, 15 insertions(+), 19 deletions(-)it would be a really good idea to actually send this to linux-bluetooth@vger.kernel.org for review.
Thanks! I have done that in v2. Eyal.