Re: [PATCH net 3/4] Revert "sh_eth: Enable Rx descriptor word 0 shift for r8a7790"
From: Ben Hutchings <hidden>
Date: 2015-02-26 16:14:56
From: Ben Hutchings <hidden>
Date: 2015-02-26 16:14:56
On Thu, 2015-02-26 at 14:21 +0000, Ben Hutchings wrote:
This reverts commit fd9af07c3404ac9ecbd0d859563360f51ce1ffde. The hardware manual states that the frame error and multicast bits are copied to bits 9:0 of RD0, not bits 25:16. I've tested that this is true for RFS1 (CRC error), RFS3 (frame too short), RFS4 (frame too long) and RFS8 (multicast).
[...] This behaviour might of course be dependent on the revision of the chip. I didn't find a chip ID register in the manual, but I found the recent patch "ARM: shmobile: Add function to get SoCs revision data for R-Car Gen2". With that patch, /proc/cpuinfo on my test system shows: Hardware : Generic R8A7790 (Flattened Device Tree) Revision : 0020 Serial : 0000000000000000 Ben.