Thread (2 messages) 2 messages, 2 authors, 2015-02-25

Re: [PATCH] e1000e: avoid incorrect ioremap/iounmap sequences for e1000_pch_spt

flat view

From: Jeff Kirsher <hidden>
Date: 2015-02-25 21:24:14

On Wed, 2015-02-25 at 14:11 -0500, John W. Linville wrote:
Commit 79849ebc0e06 (e1000e: initial support for i219) overwrites
hw->flash_addr for e1000_pch_spt MACs without doing an iounmap.
It also reuses the address without changing the areas that then
iounmap the new address (which was never explicitly ioremap'ed).
This causes iounmap to spit-out a call trace on rmmod.

This patch circumvents this issue on the early hardware that we have
in-house at Red Hat.

Signed-off-by: John W. Linville <redacted>
Cc: Jeff Kirsher <redacted>
Cc: David Ertman <david.m.ertman@intel.com>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Thanks John, your patch has been added to my queue.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help