Re: [PATCH 2/2] dsa: mv88e6131: support fixed PHYs
flat view
From: David Miller <davem@davemloft.net>
Date: 2015-02-19 20:19:41
From: Tobias Waldekranz <tobias@waldekranz.com> Date: Thu, 12 Feb 2015 15:13:17 +0100
Statically setup the PCS Control on the MAC to match the fixed PHY. Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
...
quoted hunk ↗ jump to hunk
+ /* PPU will configure MACs with physical PHYs */ + if (!fixed_phy_get_status(phy)) + return;
I kind of agree with Florian that you probably don't need this. And furthermore, this fixed_phy_get_status() interface you created isn't even used for what it's designed for. As coded, fixed_phy_get_status() returns the link status structure, but here you are only interested in whether a phy is fixed or not because you're simply making a boolean test upon whether you were given a non-NULL fixed phy status or not.