Thread (5 messages) 5 messages, 3 authors, 2015-02-20

Re: [patch] caif: fix a signedness bug in cfpkt_iterate()

flat view

From: Dan Carpenter <hidden>
Date: 2015-02-19 10:00:10
Also in: kernel-janitors

On Thu, Feb 19, 2015 at 09:49:00AM +0000, David Laight wrote:
From:  Dan Carpenter
...
quoted
Also this isn't ever going to be inlined so I removed the "inline".
...
quoted
-inline u16 cfpkt_iterate(struct cfpkt *pkt,
-			 u16 (*iter_func)(u16, void *, u16),
-			 u16 data)
static ??
There are some words missing in this sentence.


We could move this function to the header file and make it static inline
if we wanted but checksums aren't used on the fast path anyway so that's
a bit pointless.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help