Re: [PATCH net] ematch: Fix auto-loading of ematch modules.

On Mon, Feb 16, 2015 at 10:50 AM, Ignacy Gawędzki
[off-list ref] wrote:

On Mon, Feb 16, 2015 at 10:36:06AM -0800, thus spake Cong Wang:

quoted

On Mon, Feb 16, 2015 at 10:13 AM, Ignacy Gawędzki
[off-list ref] wrote:

quoted

In tcf_em_validate(), when calling tcf_em_lookup(), don't put the resulting
pointer directly into em->ops, if the function is to possibly return -EAGAIN
after module auto-loading.  Otherwise, module_put() will be called by
tcf_em_tree_destroy() on em->ops->owner, while it has already been called by
tcf_em_validate() before return.

Or simply reset em->ops to NULL after module_put()?

Yeah, why not.  I just got my inspiration from what's done in cls_api.c and
act_api.c.  What do you think, should the same simplification be applied to
cls_api.c?

I prefer the smaller change, we don't have to align with cls_api.c.
Yeah, you can always clean it up for net-next.

Thanks.