-----Original Message-----
From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]

Hello.

On 2/6/2015 4:18 PM, Sathya Perla wrote:

quoted

From: Vasundhara Volam <redacted>

quoted

BIT(x) is the preffered usage.

    Preferred.

:-) As this is a harmless spelling mistake only in the changelog,
I'll not bother sending a new patch for this!

[...]

quoted

diff --git a/drivers/net/ethernet/emulex/benet/be.h

b/drivers/net/ethernet/emulex/benet/be.h

quoted

index 3b1d59d..9869556 100644

--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h

@@ -361,15 +361,15 @@ enum vf_state {
  	ASSIGNED = 1
  };

-#define BE_FLAGS_LINK_STATUS_INIT		1
-#define BE_FLAGS_SRIOV_ENABLED			(1 << 2)
-#define BE_FLAGS_WORKER_SCHEDULED		(1 << 3)
-#define BE_FLAGS_VLAN_PROMISC			(1 << 4)
-#define BE_FLAGS_MCAST_PROMISC			(1 << 5)
-#define BE_FLAGS_NAPI_ENABLED			(1 << 9)
-#define BE_FLAGS_QNQ_ASYNC_EVT_RCVD		(1 << 11)
-#define BE_FLAGS_VXLAN_OFFLOADS			(1 << 12)
-#define BE_FLAGS_SETUP_DONE			(1 << 13)
+#define BE_FLAGS_LINK_STATUS_INIT		BIT(1)

    Not BIT(0)?

Huh, this was not intentional. I'll remember to use bit-0 the next time
we introduce a new bit!

quoted

+#define BE_FLAGS_SRIOV_ENABLED			BIT(2)
+#define BE_FLAGS_WORKER_SCHEDULED		BIT(3)
+#define BE_FLAGS_VLAN_PROMISC			BIT(4)
+#define BE_FLAGS_MCAST_PROMISC			BIT(5)
+#define BE_FLAGS_NAPI_ENABLED			BIT(6)
+#define BE_FLAGS_QNQ_ASYNC_EVT_RCVD		BIT(7)
+#define BE_FLAGS_VXLAN_OFFLOADS			BIT(8)
+#define BE_FLAGS_SETUP_DONE			BIT(9)

    So, you decided to renumber the bits?

Yes, some holes in the bit map were removed.