[PATCH] nl80211: Fix possible leak in nl80211_new_interface on MONITOR_FLAG_ACTIVE
From: Christian Engelmayer <hidden>
Date: 2015-02-14 19:52:01
Also in:
linux-wireless
Subsystem:
802.11 (including cfg80211/nl80211), the rest · Maintainers:
Johannes Berg, Linus Torvalds
In case of NL80211_IFTYPE_MONITOR and flag MONITOR_FLAG_ACTIVE, the already allocated sk_buff 'msg' is not freed, when the function exits in case the feature is not supported. Detected by Coverity CID 1269116. Signed-off-by: Christian Engelmayer <redacted> --- Compile tested only. Applies against linux-next. --- net/wireless/nl80211.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index d78fd8b54515..38a7477dda81 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c@@ -2663,8 +2663,10 @@ static int nl80211_new_interface(struct sk_buff *skb, struct genl_info *info) &flags); if (!err && (flags & MONITOR_FLAG_ACTIVE) && - !(rdev->wiphy.features & NL80211_FEATURE_ACTIVE_MONITOR)) + !(rdev->wiphy.features & NL80211_FEATURE_ACTIVE_MONITOR)) { + nlmsg_free(msg); return -EOPNOTSUPP; + } wdev = rdev_add_virtual_intf(rdev, nla_data(info->attrs[NL80211_ATTR_IFNAME]),
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html