On Tue, 3 Feb 2015, Govindarajulu Varadarajan wrote:

On Mon, 2 Feb 2015, David Miller wrote:

quoted

From: Govindarajulu Varadarajan <redacted>
Date: Sat, 31 Jan 2015 17:58:09 +0530

quoted

Signed-off-by: Govindarajulu Varadarajan <redacted>

This is terrible.

You haven't explained what this means.

And to tell you the truth, from what I can tell this tunable is
very specific to how you have implemented RX frags in the enic
driver in this series and won't necessarily translate to how
other drivers manage RX buffers.

Yes I agree that this is too specific to driver. From my knowledge mlx4 also
uses similar frag allocation from large order page. Other that these two
drivers, this facility may not make sense to other drivers.

On systems with huge memory we can go higher than order-3, and if user sees 
that
order-3 are failing, he should be able to reduce the order.

Since this is very driver specific, are you fine if I move this to device 
sysfs?

I hope there are no issues with the patch 1 & 2. Should I drop the
'changing order' patches and resend patch 1 & 2 alone?