Re: [PATCH net] pktgen: fix UDP checksum computation

On 02/04/15 at 11:08pm, Sabrina Dubroca wrote:

This patch fixes two issues in UDP checksum computation in pktgen.

First, the pseudo-header uses the source and destination IP
addresses. Currently, the ports are used for IPv4.

Second, the UDP checksum covers both header and data.  So we need to
generate the data earlier (move pktgen_finalize_skb up), and compute
the checksum for UDP header + data.

Fixes: c26bf4a51308c ("pktgen: Add UDPCSUM flag to support UDP checksums")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>

Acked-by: Thomas Graf <tgraf@suug.ch>

Thanks for fixing this.