Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips
From: Samuel Ortiz <hidden>
Date: 2015-01-30 00:11:07
Also in:
linux-devicetree, linux-wireless, lkml
Hi Clement, On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perrochaud-BPEPtVrvniRWk0Htik3J/w@public.gmane.org wrote:
quoted hunk ↗ jump to hunk
@@ -686,7 +686,7 @@ L: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org (moderated for non-subscribers) W: http://blackfin.uclinux.org/ S: Supported F: sound/soc/blackfin/* - +
Unneeded change, please remove it.
+config NFC_NXP_NCI + tristate "NXP-NCI NFC driver" + depends on NFC_NCI + default n + ---help--- + Generic core driver for NXP NCI chips.
It usually is nice to be more specific and describe which chipsets (e.g. NPC100) this driver supports among all the NXP NCI chipsets.
+struct nxp_nci_phy_ops {
+ int (*enable)(void *id);
+ int (*fw_enable)(void *id);Wouldn't a int (*enable)(void *id, enum nxp_nci_mode mode); hook be enough ? Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html