Thread (6 messages) 6 messages, 4 authors, 2015-01-28

Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver)

From: Guenter Roeck <linux@roeck-us.net>
Date: 2015-01-27 02:43:06
Also in: linux-next, lkml

On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote:
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
quoted
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
quoted
make ARCH=i386 allyesconfig fails with

drivers/staging/built-in.o: In function `reset':
(.text+0x2ae89d): multiple definition of `reset'
drivers/isdn/built-in.o:(.text+0x185dc2): first defined here
make[1]: *** [drivers/built-in.o] Error 1
Culprit:

commit b2ebd4be6fa1d2329b63531b044f9e25474981cb
Author: Thomas Petazzoni [off-list ref]
Date:   Wed Dec 31 10:11:10 2014 +0100

     staging: fbtft: add fb_agm1264k-fl driver

A global function named 'reset' isn't really a good idea.

Not that the global function with the same name in the isdn code
is better ;-).
Agreed, the fbtft code is now fixed.  Patches to fix the isdn code would
be gladly accepted as well :)
Did you have a look into the isdn code ? It will need someone
with a lot of spare time to clean this code up.

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help