6 messages, 4 authors, 2015-01-28 · open the first message on its own page
From: Jim Davis <hidden>
Date: 2015-01-22 19:10:35
make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): multiple definition of `reset' drivers/isdn/built-in.o:(.text+0x185dc2): first defined here make[1]: *** [drivers/built-in.o] Error 1
From: Guenter Roeck <linux@roeck-us.net>
Date: 2015-01-26 22:00:13
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): multiple definition of `reset' drivers/isdn/built-in.o:(.text+0x185dc2): first defined here make[1]: *** [drivers/built-in.o] Error 1
Culprit:
commit b2ebd4be6fa1d2329b63531b044f9e25474981cb
Author: Thomas Petazzoni [off-list ref]
Date: Wed Dec 31 10:11:10 2014 +0100
staging: fbtft: add fb_agm1264k-fl driver
A global function named 'reset' isn't really a good idea.
Not that the global function with the same name in the isdn code
is better ;-).
Guenter
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-01-26 22:46:58
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:quoted
make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): multiple definition of `reset' drivers/isdn/built-in.o:(.text+0x185dc2): first defined here make[1]: *** [drivers/built-in.o] Error 1Culprit: commit b2ebd4be6fa1d2329b63531b044f9e25474981cb Author: Thomas Petazzoni [off-list ref] Date: Wed Dec 31 10:11:10 2014 +0100 staging: fbtft: add fb_agm1264k-fl driver A global function named 'reset' isn't really a good idea. Not that the global function with the same name in the isdn code is better ;-).
Agreed, the fbtft code is now fixed. Patches to fix the isdn code would be gladly accepted as well :) thanks, greg k-h
From: Guenter Roeck <linux@roeck-us.net>
Date: 2015-01-27 02:43:06
On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote:
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:quoted
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:quoted
make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): multiple definition of `reset' drivers/isdn/built-in.o:(.text+0x185dc2): first defined here make[1]: *** [drivers/built-in.o] Error 1Culprit: commit b2ebd4be6fa1d2329b63531b044f9e25474981cb Author: Thomas Petazzoni [off-list ref] Date: Wed Dec 31 10:11:10 2014 +0100 staging: fbtft: add fb_agm1264k-fl driver A global function named 'reset' isn't really a good idea. Not that the global function with the same name in the isdn code is better ;-).Agreed, the fbtft code is now fixed. Patches to fix the isdn code would be gladly accepted as well :)
Did you have a look into the isdn code ? It will need someone with a lot of spare time to clean this code up. Guenter
From: Tilman Schmidt <hidden>
Date: 2015-01-27 13:04:37
Am 27.01.2015 um 03:42 schrieb Guenter Roeck:
On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote:quoted
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:quoted
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:quoted
make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): multiple definition of `reset' drivers/isdn/built-in.o:(.text+0x185dc2): first defined here make[1]: *** [drivers/built-in.o] Error 1Culprit: commit b2ebd4be6fa1d2329b63531b044f9e25474981cb Author: Thomas Petazzoni [off-list ref] Date: Wed Dec 31 10:11:10 2014 +0100 staging: fbtft: add fb_agm1264k-fl driver A global function named 'reset' isn't really a good idea. Not that the global function with the same name in the isdn code is better ;-).Agreed, the fbtft code is now fixed. Patches to fix the isdn code would be gladly accepted as well :)Did you have a look into the isdn code ? It will need someone with a lot of spare time to clean this code up.
Cleaning up the entire isdn code certainly will, but that particular problem is in fact much more limited. The function in question is declared, along with several other also much too generically named ones, in drivers/isdn/sc/card.h which is included nowhere outside drivers/isdn/sc. So these are really private functions of the SpellCaster driver which could easily be renamed. OTOH good old SpellCaster was an ISA card, and the sc driver depends on the deprecated I4L framework. I wonder if it's worth any effort. Tilman
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-01-28 17:36:55
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:quoted
make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): multiple definition of `reset' drivers/isdn/built-in.o:(.text+0x185dc2): first defined here make[1]: *** [drivers/built-in.o] Error 1Culprit: commit b2ebd4be6fa1d2329b63531b044f9e25474981cb Author: Thomas Petazzoni [off-list ref] Date: Wed Dec 31 10:11:10 2014 +0100 staging: fbtft: add fb_agm1264k-fl driver A global function named 'reset' isn't really a good idea. Not that the global function with the same name in the isdn code is better ;-).
It's been fixed in my tree for a while now :)